Fix usage with doctrine/orm 2.12.0 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In doctrinne/orm 2.12.0 AnnotationDriver no longer extend abstract AnnotationDriver class defined in doctrine/persistence
|
doctrine/orm fixes this issue in v2.12.1. See doctrine/orm#9671 But this fix will be removed in doctrine/orm v3.0 (mentioned here: https://github.com/doctrine/orm/pull/9671/files#diff-237a7d24fcc9a6e9ce16e9e17e844ee6960898377cc91af675598cf68ed929f6R14), so this PR is still valid in my opinion. |
|
Merged. Apologies that it took some time. I've tagged 3.2.0 with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doctrine/orm 2.12.0 introduced BC break:
See: https://github.com/doctrine/orm/blob/2.12.x/UPGRADE.md#bc-break-attributedriver-and-annotationdriver-no-longer-extends-parent-class-from-doctrinepersistence
I had to add
doctrine/annotationsto composer.json to make tests pass. Maybedoctrine/bundleshould be required too, if DoctrineAdapter class is usingDoctrine\Bundle\DoctrineBundle\Mapping\MappingDriver?I am not sure if this is intentional or error caused by new versions of doctrine. Seeing this package for the first time on new project. Let me know if you think this should be fixed too.